-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unregister node from RKE2 after agent deletion #12
Comments
As stated in documentation, you need to manually drain and remove node before downscaling a pool nodes. |
@remche Yes, I've seen this. The issue is that even upgrades are not stable if there is no volume on agent nodes. Is there a reason/use case to use a non volume server or node? |
@zifeo I did not manage to reproduce this issue. Can you provide a sanitized configuration ?
In my use case I only use ephemeral volume for VM w/o any problem. |
@zifeo Nice, do not hesitate to contribute back ;) |
This seems related to k3s-io/k3s#1264. As for autoscaling, I would suggest something like orchestration_stack_v1 to keep a coherent Terraform state. This should work for simple autoscaling behaviours, but a custom/vanilla cloud provider could be written for advanced use cases. |
I came to the same conclusions. Using Heat stack seems pretty hacky to me, I would prefer a custom cluster-autoscaler but it's more work :) |
@remche I will build a poc later to see how stable it could be. The issue with a custom autoscaler is the compatibility with the TF state. A remote & shared backend maybe but this seems even more hacky. |
My first though would be to use a remote state supporting locking. But I'm not sure there is a way to retrieve current backend configuration in data sources... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Node deletion seems stable so far. I am happy to bring https://github.com/zifeo/terraform-openstack-rke2 over (merge all here), but the expose module interface is rather different. What is your point of view on this? This is why I chose to start from scratch originally. |
Currently RKE2 keeps the agent as NotReady:
The text was updated successfully, but these errors were encountered: