Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using existing networks and not using floating ip? #53

Closed
kompiz opened this issue Apr 11, 2023 · 3 comments
Closed

Support for using existing networks and not using floating ip? #53

kompiz opened this issue Apr 11, 2023 · 3 comments

Comments

@kompiz
Copy link

kompiz commented Apr 11, 2023

Hi! I've made a local branch and made some somewhat hackish code to implement support for the above (my openstack provider is a bit different). If I clean it up a bit and make it presentable, would you be open for a PR?

@remche
Copy link
Owner

remche commented Apr 12, 2023

@kompiz thanks for you work on this, I would be 100% open to a PR on this.

@bagutzu
Copy link

bagutzu commented Apr 21, 2023

@kompiz I would also be interested in this PR

@kompiz
Copy link
Author

kompiz commented Apr 22, 2023

@remche @bagutzu I think I'm ready - I just want to go over the changes once more. However, there are two things I would like to bring up already:

  • I want to say already that this turned into a bigger change than I had thought - it's a bit bigger than expected.
  • I unfortunately cannot test that the ternary operators work as intended when creating new networks, and would really appreciate help in testing this.

I hope this will be OK.

Anyway stay tuned, making that PR in a day or two 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants