feat(difference, intersection): add multiset variants #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5f07e7e:
|
cjquines
reviewed
Apr 13, 2024
src/difference.ts
Outdated
| @@ -5,7 +5,7 @@ import { purry } from "./purry"; | |||
| /** | |||
| * Excludes the values from `other` array. | |||
| * | |||
| * ! **DEPRECATED**: Use `R.filter(array, R.isNot(R.isIncludedIn(other)))`. Will be removed in v2! | |||
| * ! **DEPRECATED**: The runtime implementation of this function handles duplicate values inconsistently. In v2 a new implementation would replace it; this implementation is accessible to v1 users via the `multiset` variant of this function (`R.difference.multiset`), or to maintain the same runtime implementation use `R.filter(array, R.isNot(R.isIncludedIn(other)))` instead. | |||
There was a problem hiding this comment.
suggestion:
Suggested change
| * ! **DEPRECATED**: The runtime implementation of this function handles duplicate values inconsistently. In v2 a new implementation would replace it; this implementation is accessible to v1 users via the `multiset` variant of this function (`R.difference.multiset`), or to maintain the same runtime implementation use `R.filter(array, R.isNot(R.isIncludedIn(other)))` instead. | |
| * ! **DEPRECATED**: In v2, `R.difference.multiset` will replace `R.difference`. To keep current behavior, use `R.filter(array, R.isNot(R.isIncludedIn(other)))` instead. |
eranhirsch
force-pushed
the
eranhirsch/v1/undeprecateDifference
branch
from
c8c5e28
to
dcecc69
Compare
eranhirsch
changed the title
eranhirsch
changed the title
eranhirsch
force-pushed
the
eranhirsch/v1/undeprecateDifference
branch
from
0685b81
to
5f07e7e
Compare
cjquines
approved these changes
Apr 16, 2024
|
hooray 🎉 does this make #368 no longer needed? are multiset semantics going to be our default moving-forward, and does that mean we want the other multiset helpers, or what? |
Other utilities we don't offer or don't offer correctly would need to be ported, too. For now, it's a good template for me to copy from and a reminder to do it. |
|
🎉 This PR is included in version 1.60.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a variant difference for multiset semantics and update the deprecation warning.