Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isDeepEqual): wrong dataLast types #642

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

eranhirsch
Copy link
Collaborator

@eranhirsch eranhirsch commented Apr 17, 2024

There was a bug with the typing in the dataLast version that slipped through our testing. It prevented headless usage as an equality checker for functions like differenceWith.

Fixes: #641

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fc3b152:

Sandbox Source
remeda-example-vanilla Configuration

@eranhirsch eranhirsch merged commit 7328ce2 into master Apr 17, 2024
21 checks passed
@eranhirsch eranhirsch deleted the eranhirsch/v1/fix641 branch April 17, 2024 09:41
@eranhirsch
Copy link
Collaborator Author

@cjquines - I shipped this so I can merge it into beta because I want to continue working on v2. Feel free to review it retrospectively and surface any issues you detect.

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 17, 2024

🎉 This PR is included in version 1.60.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing issue when using isDeepEqual in differenceWith function
2 participants