Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): reduceLazy -> purryFromLazy, +takeLast, lazy zip, built-in flat, and more... #672

Merged
merged 31 commits into from
May 10, 2024

Conversation

eranhirsch
Copy link
Collaborator

@eranhirsch eranhirsch commented May 5, 2024

Following re-reading the codebase before releasing v2, I went over a few more things I wanted to change:

  • take and drop shouldn't use reduceLazy.
  • drop can optimize the trivial lazy case
  • flat uses the built-in flat.
  • zipWith was funky, now less funky, and lazy.
  • lazy zip
  • optimize lazy first.
  • Add takeLast
  • Don't use copy-and-splice where slice makes sense (takeLast, dropLast, splitAt).
  • don't use internal versions where a simple JS check is enough (isEmpty)
  • Update migration docs for mapToObj
  • bump ts minimum version.
  • Remove reduceLazy. It was reimplementing parts of pipe's logic; instead, now, we rely on the way pipe handles lazy and build the rest of the APIs (dataFirst, dataLast) from it.

Copy link

codesandbox-ci bot commented May 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 43527ee:

Sandbox Source
remeda-example-vanilla Configuration

@eranhirsch eranhirsch changed the title fix(v2): a bunch of nits fix(v2): A collection of changes May 8, 2024
@eranhirsch eranhirsch marked this pull request as ready for review May 8, 2024 13:38
@eranhirsch eranhirsch requested a review from cjquines May 8, 2024 13:38
@eranhirsch eranhirsch changed the title fix(v2): A collection of changes feat(v2): A collection of changes May 8, 2024
@eranhirsch eranhirsch changed the title feat(v2): A collection of changes feat(v2): reduceLazy -> purryFromLazy, +takeLast, lazy zip, built-in flat, and more... May 8, 2024
@eranhirsch eranhirsch added the v2 PRs that are part of the v2 release label May 9, 2024
@eranhirsch eranhirsch merged commit ac35885 into beta May 10, 2024
14 checks passed
@eranhirsch eranhirsch deleted the eranhirsch/v2/randomStuff branch May 10, 2024 07:50
@TkDodo
Copy link
Collaborator

TkDodo commented May 10, 2024

🎉 This PR is included in version 2.0.0-beta.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

@TkDodo
Copy link
Collaborator

TkDodo commented May 30, 2024

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released v2 PRs that are part of the v2 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants