Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: can we merge our efforts into a single package? #10

Closed
r9y9 opened this issue Apr 1, 2016 · 3 comments
Closed

RFC: can we merge our efforts into a single package? #10

r9y9 opened this issue Apr 1, 2016 · 3 comments

Comments

@r9y9
Copy link

r9y9 commented Apr 1, 2016

Hi, thanks for your great package. Recently I have been developing pylibfreenect2 and I now think it's basically feature complete; it supports color, depth and IR transfers as well as registration functionality (which described in your TODOs). Also it's continuously tested with CI services on ubuntu and windows (on osx locally, tests are limited though).

As discussed in OpenKinect/libfreenect2#280, it would be great to avoid package duplication for the python binding. Can we merge our efforts into a single package? Do you have any thoughts on this?

@remexre
Copy link
Owner

remexre commented Apr 4, 2016

ATM I don't have enough time to maintain this package; if you can, your package can be the standard Python binding and I can mark mine undeveloped, etc.

@r9y9
Copy link
Author

r9y9 commented Apr 4, 2016

Thanks for your reply. Probably I can maintain my package at least for a while, since I'm using it right now. I'm using a different approach from you (based on cython) though, I think I've done all of your TODOs described at README;

Implement Registration.apply (in py_Registration_apply)
Make the pipeline argument of Freenect2Device's constructor actually do something
Test everything

If you get a change to look into my code and If you feel there are any missing features, please leave a comment. I will try to implement. Thanks again!

@r9y9
Copy link
Author

r9y9 commented Apr 30, 2016

I'm going to close this.

@r9y9 r9y9 closed this as completed Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants