Selection is not handled properly while setting selected text

[Losses]

Summary

When the style setting is triggered, the size of the highlighted selection area will change.

Steps to reproduce

1. Input something on remirror's official demo
2. Set some text to bold

Expected results

Only selected text turns bold, and selected

Actual results

Other text also selected

Possible Solution

Related code:

remirror/packages/remirror__core-utils/src/core-utils.ts

Line 935 in 41c4e56

export function getTextSelection(

Screenshot(s)

Credit

This bug is found by @Rolaka

[ocavue]

This is a weird bug. The selected part is wrapped in a <span class="selection"> inline decoration, which provide the background. But the DOM structure shows that this decoration should only include characters we want.

Although I don't know what the reason is, if #1282 is passed, then this bug will be fixed along with it.

---

I don't see the relation between this bug and the function getTextSelection. This function won't be called when you set some text bold.

[chunkzer]

Is this issue still outstanding? I could not reproduce it based on the initial description.

[tomas-c]

Not sure if this is exactly the same issue but if I go to https://remirror.io/ using Chrome and bold some selected text, the selection disappears:

selection-changes.mp4

[chunkzer]

Not sure if this is exactly the same issue but I go to https://remirror.io/ using Chrome and bold some selected text, the selection disappears:

selection-changes.mp4

I think selection disappearing is due to losing focus by clicking on the bold button. (You don't lose focus if you hotkey into it.)

[tomas-c]

It does not always disappear when clicking on the buttons, another example:

selection-jumping-floating-toolbard.mp4