Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not restore iframe size from saved html content #1615

Closed
dsaltares opened this issue Apr 25, 2022 · 1 comment · Fixed by #1616
Closed

Does not restore iframe size from saved html content #1615

dsaltares opened this issue Apr 25, 2022 · 1 comment · Fixed by #1616
Labels
type: bug 🪲 Something isn't working

Comments

@dsaltares
Copy link
Contributor

Summary

When using IframeExtension with the enableResizing option enabled and saving content to HTML, loading saved content does not preserve the iframe dimensions.

Steps to reproduce

  1. Enable IframeExtension with enableResizing set to true.
  2. Add iframe and resize it
  3. Save content to html
  4. Restore content from html

Expected results

The iframe size is preserved.

Actual results

The iframe size goes back to its original settings.

Possible Solution

We're parsing the iframe dimensions as strings and not as numbers. We should parse them as numbers.

Screenshot 2022-04-25 at 15 45 12

Screenshot(s)

https://www.loom.com/share/45180dd87dc349a496fcd7554e20f63c

@dsaltares dsaltares added the type: bug 🪲 Something isn't working label Apr 25, 2022
@dsaltares
Copy link
Contributor Author

Happy to send a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant