-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to add some reasoning behind coupling remirror with emotion #322
Comments
I'll be releasing the You can take a look at the emotionless social editor in the latest version of the new documentation site. https://5efe30a1a2a6dd4483635ce0--remirror.netlify.app/docs/showcase/social |
Thanks for quick reply! Is it possible to play with |
It won't be easy to play with it until it's released. Cloning, and linking is possible but with almost 80 packages, it might get tedious. I'm hoping to have a release this weekend. Whether that is possible depends on whether I bump into any bugs with the work I'm currently doing. Thanks for taking a look at I'm actually enjoying creating editors' with the new API and extensions are more understandable in my opinion. |
I think I'll try to build it myself. Is there anything undocumented that could be helpful for me to build it ? Also, is there any working example or any sort of reference I can look at using next version? |
Ok, so I've tried for a moment, was able to build it, but was not sure how to continue from there. If I'll start using 'old' version - will it be hard to migrate it later on to 'next'? |
I didn't see these replies until now. In the I'd recommend to not use the previous version as a release should be available within an hour. Please note this is the first pre-release so there will be edge cases and the API is being worked on. Your first impressions will be highly appreciated and any suggestions you have will carry a lot of weight. |
Sounds amazing! I'm checking npm every 2 hours hoping it's released :) But TBH I don't want to put pressure! Thanks again I'll share my thoughts |
So after multiple false starts, there's a release available. yarn add remirror@next @remirror/pm@next However. I've just realised it completely falls apart when wrapped in |
wooohoo! I'll play with it and let you know! Amazing work |
I'll post my 'journey journal' here, so this issue might be a bit spammy, but I'll try to describe everything I face. ps. even if I'll express a lot of feedback, keep in mind in general I'm deeply, deeply amazed! |
https://remirror.io/docs/guide/create-editor example has unclosed tags eg. |
Context is untyped (I have probably to create my type-wrapper for context) - to have all commands properly autocompleted. Typescript magic you've got is amazing, but less experienced devs might be very confused by this. Maybe it'd be good to create those hooks instead of importing them. eg. |
Oh, it's even different - it's trying to import |
So I see this in the file inside node_modules // 👋 hey!!
// you might be reading this and seeing .esm in the filename
// and being confused why there is commonjs below this filename
// DON'T WORRY!
// this is intentional
// it's only commonjs with `preconstruct dev`
// when you run `preconstruct build`, it will be ESM
// why is it commonjs?
// we need to re-export every export from the source file
// but we can't do that with ESM without knowing what the exports are (because default exports aren't included in export/import *)
// and they could change after running `preconstruct dev` so we can't look at the file without forcing people to
// run preconstruct dev again which wouldn't be ideal
// this solution could change but for now, it's working
module.exports = require("/Users/ifiokjr/Coding/kickjump/remirror/prs/packages/@remirror/pm/src/commands.ts") I thought I'll try to replace it with my own user folder just to give it a try, but I could to find proper Let me know if I can help anyhow |
Oh, that's perhaps because you've installed The fixed file is here: https://unpkg.com/browse/@remirror/pm@1.0.0-next.1/commands/dist/pm.esm.js This is the version you're seeing https://unpkg.com/browse/@remirror/pm@1.0.0-next.0/commands/dist/pm.esm.js |
By the way, thanks for this. It's really really helpful to have this feedback. |
Since I seem to keep missing you, do you want to continue the conversation on our discord channel. Might be easier to diagnose and fix issues. |
First of all, thank you so much!
I've created quite advanced text editor with raw Prosemirror:
but due to fact I'm using React, I've used tons of weird hacks and workaround to integrate it nicely with API that hides those hacks.
With time it became more and more problematic and what happens here is amazing!
However, my project is based on next.js and styled-components.
Project is integrated with styled-components (server side rendering of css etc). I'm a bit worried how would that play with emotion (which is actually very similar to styled-components).
If I want to use remirror - do I have to use emotion?
I'd be totally fine to write entire UI layer myself (which I'd like to do anyway).
In general, I'd prefer it to be fully 'renderless' - meaning it has no knowledge about how things will look. Is that possible?
If no - could you explain a bit what this integration means, how it works etc.
Thank you so much!
The text was updated successfully, but these errors were encountered: