Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of export * for better tree shaking #406

Closed
2 tasks done
ifiokjr opened this issue Jul 29, 2020 · 1 comment · Fixed by #430
Closed
2 tasks done

Remove use of export * for better tree shaking #406

ifiokjr opened this issue Jul 29, 2020 · 1 comment · Fixed by #430
Labels
good first issue Good for newcomers

Comments

@ifiokjr
Copy link
Member

ifiokjr commented Jul 29, 2020

Description

Looking at bundlephobia it seems as though any import from the remirror codebase results in importing the whole library.

I suspect it might be the over zealous usage of export *.

  • Remove all package boundary export * statement and replace with named exports.

Checklist

image

@ifiokjr ifiokjr added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 29, 2020
@ifiokjr ifiokjr mentioned this issue Aug 1, 2020
4 tasks
@ifiokjr ifiokjr removed the help wanted Extra attention is needed label Aug 1, 2020
@ifiokjr
Copy link
Member Author

ifiokjr commented Aug 2, 2020

For anyone looking at this. In the end this change had zero impact on the overall bundle size. Tree shaking works with both export * and export { Named }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant