Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate AttributesExtension in favour of SchemaExtension #589

Closed
ifiokjr opened this issue Aug 27, 2020 · 1 comment
Closed

Deprecate AttributesExtension in favour of SchemaExtension #589

ifiokjr opened this issue Aug 27, 2020 · 1 comment
Assignees
@ifiokjr
Labels
type: deprecation 🗑️ A public export or internal package has been deprecated. type: feature ✨ A new feature is being added to the public API type: refactor ♻️ A pull request that primarily focuses on refactoring code.
Projects
remirror@1.0.0 Internal Roadmap
Milestone
Core Improvements

Comments

@ifiokjr
Copy link
Member

ifiokjr commented Aug 27, 2020 •
edited

Description

The AttributesExtension adds attributes to the top level node. However, this is now possible by adding extra attributes to the doc node.

EDIT: I ran into this thread outlining that the doc node can't be updated and needs a special transform step to be created to activate runtime updates.
@ifiokjr ifiokjr added type: deprecation 🗑️ A public export or internal package has been deprecated. type: refactor ♻️ A pull request that primarily focuses on refactoring code. labels Aug 27, 2020
@ifiokjr ifiokjr self-assigned this Aug 27, 2020
@ifiokjr ifiokjr added the type: feature ✨ A new feature is being added to the public API label Aug 29, 2020
@ifiokjr ifiokjr added this to To do in remirror@1.0.0 via automation Aug 29, 2020
@ifiokjr ifiokjr added this to Future in Internal Roadmap via automation Aug 29, 2020
@ifiokjr ifiokjr added this to the Core Improvements milestone Aug 29, 2020
@ifiokjr
Copy link
Member Author

ifiokjr commented Sep 8, 2020

Not going to happen since it's important that things like focus and className can be stored on the main element without being persisted in the saved JSON. However, there still needs to be a way to store data on the doc node, for example when creating a migration version for the doc, or when setting the document as rtl or ltr.

I'll open a new issue when these become a priority.

@ifiokjr ifiokjr closed this as completed Sep 8, 2020
remirror@1.0.0 automation moved this from To do to Done Sep 8, 2020
Internal Roadmap automation moved this from Future to Released Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ifiokjr ifiokjr

Labels
type: deprecation 🗑️ A public export or internal package has been deprecated. type: feature ✨ A new feature is being added to the public API type: refactor ♻️ A pull request that primarily focuses on refactoring code.
Projects
Internal Roadmap
  
Released
remirror@1.0.0
  
Done
Milestone
Core Improvements
Development

No branches or pull requests
1 participant
@ifiokjr