Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out broken cypress tests #13

Closed
kentcdodds opened this issue Mar 16, 2022 · 1 comment
Closed

Figure out broken cypress tests #13

kentcdodds opened this issue Mar 16, 2022 · 1 comment

Comments

@kentcdodds
Copy link
Member

I'm not sure what happened, but suddenly the cy.login() functionality stopped working. Here's the last successful build: https://github.com/remix-run/grunge-stack/actions/runs/1994316486 Could be #10, or #11 (or maybe something completely unrelated 🙃)
@kentcdodds
Copy link
Member Author

I'm pretty confident Cypress is busted with the way it manages cookies: cypress-io/cypress#20476

We're doing some workarounds, but basically I removed the cleanupUser from this codebase because the database is in-memory anyway so it's probably fine. Maybe we can bring it back if that cypress issue is fixed.

@mcansh mcansh mentioned this issue Jul 8, 2022
Closed
@machour machour mentioned this issue Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kentcdodds