Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should ARC_APP_SECRET also be mentioned under Deployment in the docs? #31

Closed
fzembow opened this issue Mar 20, 2022 · 2 comments · Fixed by #33
Closed

Should ARC_APP_SECRET also be mentioned under Deployment in the docs? #31

fzembow opened this issue Mar 20, 2022 · 2 comments · Fixed by #33

Comments

@fzembow
Copy link
Contributor

fzembow commented Mar 20, 2022

It's my first time using Architect, and I've really enjoyed Remix! Really excited about this combo.

When following the getting started guide, in the Deployment section

⚠️ Warning: The environment variable "ARC_APP_SECRET" is not set - please set this in production to help mitigate potential session-related attacks!

Looking at the Architect docs on security, it definitely seems important to set.

Perhaps

npx arc env --add --env production ARC_APP_SECRET $(openssl rand -hex 32)

Should be added to the docs above the other production secret being set? I can make a quick PR if that makes sense.

@kentcdodds
Copy link
Member

Cc @tbeseda sound good?

@tbeseda
Copy link
Contributor

tbeseda commented Mar 21, 2022

@fzembow @kentcdodds Yep, good call. I think both staging and production should have this set.

fzembow added a commit to fzembow/grunge-stack that referenced this issue Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants