Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push and replace should support query argument, per docs #144

Closed
robyoder opened this issue Nov 19, 2015 · 3 comments
Closed

push and replace should support query argument, per docs #144

robyoder opened this issue Nov 19, 2015 · 3 comments

Comments

@robyoder
Copy link

The API docs give the following examples:

history.createPath('/the/path', { the: 'query' })
history.pushState(null, '/the/path', { the: 'query' })
history.push('/the/path', { the: 'query' })
history.replace('/the/path', { the: 'query' }, { the: 'state' })

However, the ability to pass a query to push or replace was removed in ee7bea7. There are comments there (at the bottom) objecting to the change, and I agree that query should be supported there. The docs should be updated, however, to remove the state parameter from replace in the last example above.

@robyoder robyoder changed the title push and replace do not support query argument, contrary to docs push and replace should support query argument, per docs Nov 19, 2015
@taion
Copy link
Contributor

taion commented Nov 19, 2015

This is fully superseded by #141, FWIW.

@robyoder
Copy link
Author

Interesting.

@taion
Copy link
Contributor

taion commented Nov 20, 2015

Closing this as superseded by the mentioned PR.

@taion taion closed this as completed Nov 20, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants