Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createBrowserHistory throws error in IE9 #65

Closed
pucka opened this issue Sep 23, 2015 · 2 comments
Closed

createBrowserHistory throws error in IE9 #65

pucka opened this issue Sep 23, 2015 · 2 comments

Comments

@pucka
Copy link

pucka commented Sep 23, 2015

When using createBrowserHistory IE9 throws an error. Object doesn't support property or method 'replaceState'

This is likely because of the window.history.replaceState({ ...historyState, key }, null, path) call in getCurrentLocation method.

EDIT: this only tested with react-router
@knowbody
Copy link
Contributor

This is because IE9 does not support session history management, more here.

Also more docs about Histories in the React Router docs.

@pucka
Copy link
Author

pucka commented Sep 23, 2015

Yes i know, and the docs it says that it will detect for this and fallback to page reloads only. Now you will get this JS error on load and all JS will break.

EDIT: I found this PR now that will solve this problem #44

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pucka @knowbody