Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed.js when starting a Typescript project #113

Closed
joeleonard212 opened this issue Jun 26, 2022 · 5 comments · Fixed by #127
Closed

Seed.js when starting a Typescript project #113

joeleonard212 opened this issue Jun 26, 2022 · 5 comments · Fixed by #127
Assignees

Comments

@joeleonard212
Copy link

joeleonard212 commented Jun 26, 2022

Have you experienced this bug with the latest version of the template?

remix-run/indie-stack blog-tutorial

Steps to Reproduce

run command:

npx create-remix --template remix-run/indie-stack blog-tutorial

then choose:

Typescript

Expected Behavior

in the prisma module, should be a file called seed.ts

Actual Behavior

the actual file is seed.js and some errors are occuring when using it

@MichaelDeBoey
Copy link
Member

This is probably related to the changes from #106

@joeleonard212 Could you please explain the error that you're seeing?

@mcansh
Copy link
Contributor

mcansh commented Jun 27, 2022

yeah @joeleonard212 I'm not seeing any issues on a freshly created indie-stack so if there's any specific errors you're seeing that would be helpful https://gist.github.com/mcansh/8e4bfd21f2f8de96ab00989d8aa15154

@joeleonard212
Copy link
Author

joeleonard212 commented Jun 27, 2022

yeah, this error is referred to the blog-tutorial.

I mean, picking the typescript flavour I was expecting to find Prisma in typescript as well.

The seed.js cannot be parsed correctly with the following error:

Parsing error: Cannot find module '@babel/preset-react'

basically, this breaks the workflow of the tutorial. not sure if fixing this dependency would solve, maybe other error would occur later

@moishinetzer
Copy link
Contributor

moishinetzer commented Jul 17, 2022

This is probably related to the commit which changed the prisma seed command to use node instead of ts-node and changed seed.ts to seed.js.

Could you revert the above changes in package.json and see if that fixes anything?

@flyingwolf1701
Copy link

flyingwolf1701 commented Aug 5, 2022

Hello @moishinetzer I did try and change my code to reflect what you said. Additionally in app/posts/index.tsx I had to replace the first two lines with:

import { PrismaClient } from "@prisma/client"; import bcrypt from "bcryptjs";

from

const { PrismaClient } = require("@prisma/client"); const bcrypt = require("bcryptjs");

I think the issue is that the blog tutorial hasn't bee updated. The problem I am getting is:

Property 'post' does not exist on type 'PrismaClient<PrismaClientOptions, never, RejectOnNotFound | RejectPerOperation | undefined>'.

That issue is pointing at the line given in the tutorial:
for (const post of posts) { await prisma.post.upsert({ where: { slug: post.slug }, update: post, create: post, }); }

It doesn't like the post in await prisma.post.upsert.
I am guessing that the post type in PrismaClientOptions is also screwed up. I am sure this little issue is making a lot of new people turn away from Remix which is a shame because this is pretty amazing stuff.

It would be really amazing if the tutorial was made functional again! Lord knows I am trying but I don't understand the core technologies enough yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants