Improve remix-architect isBinaryType performance

[gyx1000]

I'm starting to explore the beautiful remix project.

I noticed that the isBinaryType function of the remix-architect adapter has a complexity of O(N*includesComplexity)

Would it be possible to convert the binaryTypes list to Set and split the contentType variable by ; (relative to rfc7231) and do something like that to have O(1) complexity?

export function isBinaryType(contentType: string | null | undefined) {
  if (!contentType) return false;
  let [test, ] = contentType.split(';');
  return binaryTypes.has(test);
}

Thanks again for this wonderful project.

[machour]

@gyx1000 Welcome to the community 🙌
Could you open a PR targeting the dev branch with your changes? It would make it way easier for the team to review.

[gyx1000]

Hi @machour,

I opened #4761

[machour]

Thanks! We just need you to sign the CLA by adding your name to the contributors.yml file and we'll be good to go.