Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pnpm, route content doesn't show #147

Closed
itsMapleLeaf opened this issue May 10, 2021 · 3 comments
Closed

Using pnpm, route content doesn't show #147

itsMapleLeaf opened this issue May 10, 2021 · 3 comments

Comments

@itsMapleLeaf
Copy link
Contributor

itsMapleLeaf commented May 10, 2021

Reproduction steps:

  1. Install pnpm
  2. Set up a new remix project pnpm init remix, say "no" to automatic install
  3. Install dependencies: pnpm install
  4. Run the dev server: pnpm run dev

(technically, only 3. needs to use pnpm over npm, but consistency 🤷)

This is what shows, just the footer, no route content

image

As suggested with some help from @JNaftali, I tried to change the "remix" imports to "@remix-run/node" and "@remix-run/react" where appropriate, but still ran into the same issue.

I think the solution might be for the remix package to declare hard dependencies on the react and node packages

@tylerbrostrom
Copy link
Contributor

Not sure if this is relevant, but a common issue is that pnpm doesn't implicitly run post and pre scripts. Maybe there's a postinstall hook that isn't running? See https://pnpm.io/cli/run#differences-with-npm-run

@tylerbrostrom
Copy link
Contributor

Methinks this be a duplicate of #154.

@machour
Copy link
Collaborator

machour commented Mar 15, 2022

Tracked in #154

@machour machour closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants