Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗺️ CSS Modules #4632

Closed
2 tasks done
markdalgleish opened this issue Nov 17, 2022 · 8 comments
Closed
2 tasks done

🗺️ CSS Modules #4632

markdalgleish opened this issue Nov 17, 2022 · 8 comments
Assignees
Milestone

Comments

@markdalgleish
Copy link
Member

markdalgleish commented Nov 17, 2022

Progress

Open questions

  • What format should we use for scoped class names and should it differ between dev and prod? Should it be configurable? e.g. it's common to have debuggable class names during development, like .Button-module__root__a4X9gs, but only emit the hash in production, like .a4X9gs.

Notes

This work will also support node_modules that import "./blah.css" and import {} from "./blah.module.css" so that folks design systems don't blow up.

@markdalgleish markdalgleish self-assigned this Nov 17, 2022
@machour machour changed the title CSS Modules 🗺️ CSS Modules Nov 18, 2022
@ryanflorence
Copy link
Member

@jacob-ebey can you find the package that generates types and link it here?

@jacob-ebey
Copy link
Member

https://www.npmjs.com/package/typescript-plugin-css-modules

@tigerabrodi

This comment was marked as off-topic.

@laurencefass

This comment was marked as off-topic.

@machour

This comment was marked as off-topic.

@laurencefass

This comment was marked as off-topic.

@remix-run remix-run locked as off-topic and limited conversation to collaborators Nov 30, 2022
@markdalgleish
Copy link
Member Author

I noticed that a note had been added to this issue about CSS side effect imports (import "./styles.css") but in my mind this is a separate piece of work that builds on top of this foundation. I've split out a standalone proposal for this: #4775

@markdalgleish
Copy link
Member Author

Next steps: @chaance to follow up on PR review changes, approve if everything looks good.

@ryanflorence ryanflorence added this to the v1.11 milestone Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

6 participants