Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix v2_meta to use leaf meta #5038

Closed
ryanflorence opened this issue Jan 9, 2023 · 0 comments
Closed

fix v2_meta to use leaf meta #5038

ryanflorence opened this issue Jan 9, 2023 · 0 comments
Assignees
@chaance
Labels
bug Something isn't working

Comments

@ryanflorence
Copy link
Member

ryanflorence commented Jan 9, 2023 •
edited

Currently v2_meta uses the "leaf match" rather than the "leaf match with a meta export". We want the second.

Given a set of matches, where "yes" means it exports meta and "no" means it doesn't...

matches w/ meta index of meta used
[y, n, n] 0
[y, y, n] 1
[y, n, y] 2
[n, y, n] 1
[n, n, y] 2

etc.
@ryanflorence ryanflorence changed the title Update v2_meta to use leaf meta 🗺️ Update v2_meta to use leaf meta Jan 9, 2023
@ryanflorence ryanflorence changed the title 🗺️ Update v2_meta to use leaf meta fix v2_meta to use leaf meta Jan 9, 2023
@ryanflorence ryanflorence added the bug Something isn't working label Jan 9, 2023
@chaance chaance mentioned this issue Jan 10, 2023
Merged
2 tasks
@chaance chaance closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaance chaance

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanflorence @chaance