Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<LiveReload port={12345} /> doesn't change port #6319

Closed
1 task done
lukasa1993 opened this issue May 5, 2023 · 3 comments · Fixed by #6476
Closed
1 task done

<LiveReload port={12345} /> doesn't change port #6319

lukasa1993 opened this issue May 5, 2023 · 3 comments · Fixed by #6476
Assignees
Labels
bug:unverified feat:dx Issues related to the developer experience package:dev

Comments

@lukasa1993
Copy link

lukasa1993 commented May 5, 2023

What version of Remix are you using?

1.16

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

Expected Behavior

port must change

Actual Behavior

port is always taken from remix.config file instead of supplied port to component

Findings

let port = (window.__remixContext && window.__remixContext.dev && window.__remixContext.dev.websocketPort) || ${String(

here supplied port is grabbed last but window.__remixContext.dev.websocketPort this is always set so port supplied to component is ignored

@brophdawg11 brophdawg11 added package:dev feat:dx Issues related to the developer experience labels May 5, 2023
@pcattori pcattori self-assigned this May 5, 2023
@pcattori pcattori linked a pull request May 25, 2023 that will close this issue
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-33cc4c0-20230525 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

🤖 Hello there,

We just published version 1.17.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

🤖 Hello there,

We just published version 1.17.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:unverified feat:dx Issues related to the developer experience package:dev
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants