Remix v1.16.0 - Unnecessary Node polyfills added for Oxygen/Workers.

[frandiox]

What version of Remix are you using?

1.16.0

Are all your remix dependencies & dev-dependencies using the same version?

• Yes

Steps to Reproduce

I think this was introduced in #5274 , and is probably related to #6280 and its linked issues/PRs. I'm still writing this issue to show that it also affects Worker environments

You can reproduce the issue when building a project with a typical config for Oxygen or CFW:

module.exports = {
  appDirectory: 'app',
  ignoredRouteFiles: ['**/.*'],
  server: './server.ts',
  serverMainFields: ['browser', 'module', 'main'],
  serverConditions: ['worker', process.env.NODE_ENV],
  serverDependenciesToBundle: 'all',
  serverModuleFormat: 'esm',
  serverPlatform: 'neutral',
  serverMinify: false, // To check the bundle later
};

Expected Behavior

The resulting server/worker bundle shouldn't contain Node polyfills. Or, at least, they shouldn't make the bundle crash when running on a Worker environment.

Actual Behavior

Many Node polyfills are added to the JS and Server bundles, thus increasing the size by ~60K non-minified. One of the polyfills is also accessing a global navigator variable, making the process exit with navigator is not defined in Worker environments:

---

I'm not sure if the solution is modifying this conditional and skip when serverPlatform === 'neutral', or perhaps passing different options to esbuild-plugin-polyfill-node since it seems to have a different default behavior compared to the old @esbuild-plugins/node-modules-polyfill.

[MichaelDeBoey]

We just published version 1.17.1-pre.0 which includes #6562 (a possible fix). If you'd like to take it for a test run please try it out and let us know what you think!

[frandiox]

Thanks! I can confirm that #6562 fixes this issue. Should we close it now or wait until 1.17.1 is released?

[MichaelDeBoey]

Closed by #6562

[github-actions]

🤖 Hello there,

We just published version 1.17.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!