Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent casing for websocketPort option #6419

Closed
1 task done
kj opened this issue May 18, 2023 · 3 comments · Fixed by #6476
Closed
1 task done

Inconsistent casing for websocketPort option #6419

kj opened this issue May 18, 2023 · 3 comments · Fixed by #6476

Comments

@kj
Copy link

kj commented May 18, 2023

What version of Remix are you using?

1.16.1

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

Try to set the websocket port via the future.unstable_dev.websocketPort config option.

Expected Behavior

The browser connects to the specified websocket port.

Actual Behavior

The browser still tries to connects to the default port 3001, ignoring the config.

This is because there is inconsistency in the source code. Some files refer to the config key as websocketPort (as documented in release notes), while others refer to it as webSocketPort (with an uppercase 'S' for Socket). I think this inconsistency was introduced in 1.16.1, as if memory serves it was working in 1.16.0.

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-33cc4c0-20230525 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

🤖 Hello there,

We just published version 1.17.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

🤖 Hello there,

We just published version 1.17.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants