Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulepreload does not work on client navigation #6657

Closed
1 task done
celebro opened this issue Jun 21, 2023 · 3 comments
Closed
1 task done

Modulepreload does not work on client navigation #6657

celebro opened this issue Jun 21, 2023 · 3 comments

Comments

@celebro
Copy link

celebro commented Jun 21, 2023

What version of Remix are you using?

1.17.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

Open https://remix.run/ and browser network devtools. Navigate to blog. (I noticed this on on my own application running remix 1.17.0, but remix.run website exhibits the same problem)

Expected Behavior

All javascript modules / chunks should preload at start of navigation.

Actual Behavior

Only main route javascript loads, additional chunks only start loading after main javascript completes, despite all assets being available in the manifest. Preloading only works on initial page load, but not on client navigation.

Screenshot 2023-06-21 at 09 56 10

From quick search it looks like the change was introduced here: f717d02e#diff-594d4b6ed5bd4abff7e9319566b5505b6a85753e665ff4d2113e888384a98377R1090 ?

@brophdawg11
Copy link
Contributor

Are you sure this behaved differently in the past? I don't think this is something introduced in 1.17.0 because the https://remix.run website is still on 1.15.0 but the referenced change (#6455) was introduced in 1.17.0. Could you let us know if this was working on your app on previous versions?

@celebro
Copy link
Author

celebro commented Jun 22, 2023

Yeah, you're right, I checked out older version and it never worked, I guess I just assumed based on initial page load it should. Should I open a feature request instead?

@brophdawg11
Copy link
Contributor

Yeah I can just convert this issue to a Proposal Discussion

@remix-run remix-run locked and limited conversation to collaborators Jun 22, 2023
@brophdawg11 brophdawg11 converted this issue into discussion #6666 Jun 22, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

2 participants