Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheme not set to HTTPS when TLS config options are set in remix.config.js #6718

Closed
1 task done
aydrian opened this issue Jun 28, 2023 · 3 comments · Fixed by #6724
Closed
1 task done

Scheme not set to HTTPS when TLS config options are set in remix.config.js #6718

aydrian opened this issue Jun 28, 2023 · 3 comments · Fixed by #6724
Labels
bug:unverified package:dev

Comments

@aydrian
Copy link

aydrian commented Jun 28, 2023

What version of Remix are you using?

1.18

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

Set tlsKey and tlsCert in remix.config.js for v2_dev

Expected Behavior

scheme gets set to HTTPS

Actual Behavior

scheme gets set to HTTP
@pcattori pcattori mentioned this issue Jun 29, 2023
Merged
2 tasks
@pcattori pcattori linked a pull request Jun 29, 2023 that will close this issue
fix(dev): better networking options #6724
Merged
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-5ad8fa5-20230704 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot closed this as completed Jul 4, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:unverified package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dev): better networking options remix-run/remix
2 participants
@aydrian @brophdawg11