Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Additional Selectors with Key Value Pairs #12

Open
remkade opened this issue Nov 1, 2022 · 1 comment
Open

Support Additional Selectors with Key Value Pairs #12

remkade opened this issue Nov 1, 2022 · 1 comment

Comments

@remkade
Copy link
Owner

remkade commented Nov 1, 2022

Right now the parser understands key value pairs that are not simple equality. For example: [subdir != "win-64] is valid and understood. However, you can't yet do anything with it yet. Lets support this properly and make the matching logic understand it.

Examples

Here's some possible sensible use cases:

[license != "GPL-3"]
[build_number > 2]
[subdir != "win*"]

Here's some that shouldn't work:

[license >= "GPL-3"] # doesn't make sense
[build >= "hdfdf_py39" ] # No way to do greater than on a string like this with out causing surprises
[sha256< "abcdef12345"]
@razzlestorm
Copy link
Collaborator

If we are adding equality checking for things like license and sha256 and the like, does this mean we're going to have to add those attributes to the MatchSpec struct? I've gotten rusty in my Rust, so I apologize if this is an obvious question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants