Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra/Duplicate dependency of jline-console in picocli-shell-jline3 (pom.xml/build.gradle) #1516

Closed
kaushalkumar opened this issue Dec 14, 2021 · 2 comments
Labels
theme: shell An issue or change related to interactive (JLine) applications type: dependency 📚
Milestone

Comments

@kaushalkumar
Copy link
Contributor

pom.xml/build.gradle of picocli-shell-jline3 defines a compile time dependency on jline and jline-console. The second dependency of jline-console is unwanted as jline contains all the required dependency including the classes of jline-console. Ref: https://github.com/jline/jline3#artifacts. The dependency of jline-console pulls other individual jars of jline in maven classpath.
These additional dependency jars throws warning when we use proguard maven plugin to optimise the package. A snippet of the warning is "Note: duplicate definition of library class [org.jline.console.ArgDesc]".

Can we please remove the extra dependency from build.gradle.

@remkop
Copy link
Owner

remkop commented Dec 16, 2021

@kaushalkumar Thank you for raising this!
Will you be able to provide a pull request for this?

@remkop remkop added this to the 4.6.3 milestone Dec 16, 2021
@remkop remkop added type: dependency 📚 theme: shell An issue or change related to interactive (JLine) applications labels Dec 16, 2021
@remkop remkop closed this as completed in b478280 Jan 18, 2022
@remkop
Copy link
Owner

remkop commented Jan 18, 2022

I pushed a fix for this, and this will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: shell An issue or change related to interactive (JLine) applications type: dependency 📚
Projects
None yet
Development

No branches or pull requests

2 participants