Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

andTestButSkipWhenNull() does not execute the transformation code during test #25

Closed
thombergs opened this issue Oct 2, 2017 · 3 comments
Closed

andTestButSkipWhenNull() does not execute the transformation code during test #25

thombergs opened this issue Oct 2, 2017 · 3 comments
Milestone
2.0.0 API fixes

Comments

@thombergs
Copy link
Contributor

The javadoc states

In a future release this method may allow to test the transformation function.

so there just seems some functionality missing?
@schuettec
Copy link
Contributor

Yes this method should be deleted. Earlier it was designed to assert the transform function to make sure the same instance is configured in the mapper. But since lambdas cannot be compared, this method does not make any sense.

@schuettec
Copy link
Contributor

This method should not be deleted but renamed to andSkipWhenNull() since we need the information that the skip-when-null-behaviour is expected.

@schuettec schuettec added this to the 2.0.0 API fixes milestone Oct 9, 2017
@schuettec
Copy link
Contributor

Will be available in version 2.0.0.

@schuettec schuettec mentioned this issue Jan 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0 API fixes
Development

No branches or pull requests
2 participants
@thombergs @schuettec