Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set last timer as new default #16

Closed
wants to merge 1 commit into from
Closed

set last timer as new default #16

wants to merge 1 commit into from

Conversation

hollesse
Copy link
Member

fixes #9

@hollesse hollesse added the enhancement New feature or request label Oct 10, 2022
@gregorriegler
Copy link
Contributor

Ok, so it sets the default now. I don't understand if this is the behaviour simon wanted, but it looks good to me.

@hollesse
Copy link
Member Author

That was what I understood from his answer on twitter. Is that what you meant @simonharrer ?

@simonharrer
Copy link
Member

No, it was simply a statement that there are two concepts. Would not merge this in this state. Last value and custom value are two different concepts, and I don’t think mixing them is good. We either support both or focus on one. I think the custom value is more valuable as I can set the typcial value (we rotate after 8inutes) nd sometimes deviate from that. i don’t want to lose my typical value because of the one deviation, having to type the custom value in again.

@gregorriegler
Copy link
Contributor

Ok, what would be an example you liked better

@simonharrer
Copy link
Member

I know of no easy way that makes the UI more complicated. I just want my custom value, the fixed, usual, team agreed upon rotation time, to stay the same and not to be changed when I select another one for a special occasion.

@hollesse
Copy link
Member Author

Should we then have an option to set default values for a room? But these would then be reset with every release. Or should we allow the users to set their default and save it in their local storage?

@simonharrer
Copy link
Member

Again, not easy because some people create new rooms per feature whereas some always stay in their specific room. Habing a default value for a room is only helpful for a team that doesn’t change the room, and without persistence storage it just doesn’t work.

@gregorriegler
Copy link
Contributor

@simonharrer one question: what is that special occasion, when you want to change the timer? Do you have an example?
I'm asking because it sounds like what you want is more time, which a "Pause Button" could also solve.

@simonharrer
Copy link
Member

Examples:

  • Let's time box this and come back in 30 minutes.
  • We talked so much, let's extend the timer by 5 more minutes.
  • We forgot to start the timer, let's just say 5 minutes and then we switch.

@hollesse
Copy link
Member Author

As I understand your points it then could be a solution to alle the user to set his/her default value for the timer. The the user can use this timer regularly and if they need another timer use the drop-down. But that would not solve the need for custom timers. For that we could also add user specific settings

@simonharrer
Copy link
Member

As I understand your points it then could be a solution to alle the user to set his/her default value for the timer. The the user can use this timer regularly and if they need another timer use the drop-down.

That is the currently implemented solution, with the "default" value configured on the web and stored in localStorage per user.

But that would not solve the need for custom timers. For that we could also add user specific settings

The question is: is there really a need for that? I haven't had that need in my coachings.

@gregorriegler
Copy link
Contributor

What if we turn that 'increasing of the current timer' into a separated UI/UX concept.

So whenever a Timer is started and running, you can click and drag the current timer display, and it will change the time accordingly. So I forgot to start the timer, so I start it now, and then I click inside the timer display (while it already runs) and I drag it to the left. While I'm dragging, the timer visibly changes first to 9 minutes, then to 8, 7, 6, 5 and then I release my mouse button on 5, and the timer continues.

I think it would be cool. And it would solve our problem. However, people won't easily discover that feature by themselves.

@simonharrer
Copy link
Member

Cool idea, but most people use the CLI anyway, so would be a huge invest for a feature only very very few people will use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last timer
3 participants