Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make editor contexts independent from each other #1642

Closed
JonnyBurger opened this issue Jan 3, 2023 · 3 comments
Closed

Make editor contexts independent from each other #1642

JonnyBurger opened this issue Jan 3, 2023 · 3 comments

Comments

@JonnyBurger
Copy link
Member

Right now clicking one button triggers rerender of all editor contexts in EditorContext.tsx. Should refactor each context to be independent
@tonie-ng
Copy link

tonie-ng commented Mar 7, 2023

@JonnyBurger Could you throw more light on this issue?

@JonnyBurger
Copy link
Member Author

Many functionalities are using the same context, which means if one setting changes, many updates are happening. We can optimize it by spreading it out

@JonnyBurger
Copy link
Member Author

Implemented in the v4 branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JonnyBurger @tonie-ng