Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause video while waiting for buffer loading #1991

Closed
Jidzo1 opened this issue Apr 5, 2023 · 1 comment · Fixed by #2013
Closed

Pause video while waiting for buffer loading #1991

Jidzo1 opened this issue Apr 5, 2023 · 1 comment · Fixed by #2013

Comments

@Jidzo1
Copy link

Jidzo1 commented Apr 5, 2023

(REMOTION PLAYER)

Opening this issue to handle the video loading while the internet connection is downloading video data.

The goal would be to have a way to block the video and add a loading spinner for instance while the buffer is loading.
Instead of having the video and sound continue and cut on it.

Because right now having the video continue with the sound that cuts in and out, and the video loading part of it is not a good user experience. (both image and sound are feeling buggy when this is happening)

Thanks for looking into this!

@JonnyBurger
Copy link
Member

Thanks for filing the issue!

Indeed, we should give some official guidance what happens when a video that you want to play is buffering.
Ideally we also pause the player until the videos have been loaded and resume once the video has been unblocked.

I think this can be done without changes to the Remotion core by attaching event listeners, but we will add some documentation and examples for this.

@JonnyBurger JonnyBurger linked a pull request Apr 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants