Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlayerMethods isFullscreen is defined as () => void; #2140

Closed
kacperadach opened this issue Apr 24, 2023 · 1 comment 路 Fixed by #2144
Closed

PlayerMethods isFullscreen is defined as () => void; #2140

kacperadach opened this issue Apr 24, 2023 · 1 comment 路 Fixed by #2144
Labels
bug Something isn't working

Comments

@kacperadach
Copy link

Bug Report 馃悰

remotion/packages/player/src/player-methods.ts

Line 17 in e032d48

isFullscreen: () => void;

Shouldn't this be () => boolean? The documentation says it returns a boolean indicating whether the player is in fullscreen or not.
@kacperadach kacperadach added the bug Something isn't working label Apr 24, 2023
@JonnyBurger
Copy link
Member

Indeed seems like a bug to me!
Will try to provide a fix soon. Thanks for reporting it!

@JonnyBurger JonnyBurger linked a pull request Apr 25, 2023 that will close this issue
fix isFullscreen returning void in the TypeScript signature #2144
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix isFullscreen returning void in the TypeScript signature remotion-dev/remotion
2 participants
@JonnyBurger @kacperadach