Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nitpick in remotion/init.ts for create-video package. #605

Closed
sohamsshah opened this issue Sep 25, 2021 · 1 comment
Closed

Nitpick in remotion/init.ts for create-video package. #605

sohamsshah opened this issue Sep 25, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@sohamsshah
Copy link
Contributor

Bug Report 馃悰

remotion/packages/create-video/src/init.ts

Line 215 in 6472f88

short: template.name,

In short attribute, shouldn't we have template.shortName instead of template.name?

Was actually trying to understand the codebase; had a question around if this is a bug or not.
@sohamsshah sohamsshah added the bug Something isn't working label Sep 25, 2021
@JonnyBurger
Copy link
Member

Thanks for pointing this out! Based on this code https://github.com/terkelg/prompts/blob/d7d2c37a0009e3235b2e88a7d5cdbb114ac271b2/lib/elements/select.js#L29

My investigation led me to believe that the short option has no effect at all. I will remove this property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JonnyBurger @sohamsshah