Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css reset overwrites inherited properties #608

Closed
sashee opened this issue Sep 29, 2021 · 2 comments
Closed

Css reset overwrites inherited properties #608

sashee opened this issue Sep 29, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@sashee
Copy link

sashee commented Sep 29, 2021

I've updated to 2.4.0 and all texts disappeared from the videos. I drilled down and it seems like the css-reset overwrites inherited properties.

Here's a screenshot of a component:
image

Notice that the color: var(--color-foreground); is crossed (~bottom right corner). It is overwritten by the .css-reset * rule:

image

Since the .css-reset * is more specific than the div.marpit > section (that is the ancestor of the h1) it overwrites the color with white.

Since all the properties in the .css-reset are inherited, the * should be removed.

@sashee sashee added the bug Something isn't working label Sep 29, 2021
@JonnyBurger
Copy link
Member

Thanks a lot for reporting! Indeed an annoying regression, sorry for it! Just published v2.4.1 to fix it.

@sashee
Copy link
Author

sashee commented Sep 29, 2021

That was fast:) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants