Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI incompatible with yarn workspaces #805

Closed
kaylendog opened this issue Jan 28, 2022 · 3 comments
Closed

CLI incompatible with yarn workspaces #805

kaylendog opened this issue Jan 28, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@kaylendog
Copy link
Contributor

Bug Report 馃悰

When running yarn start on a project created with yarn create video inside a yarn workspace, the CLI launches, but crashes once the bundle has been built:

/Users/skyezer/Projects/my-cool-project/node_modules/@remotion/bundler/dist/get-package-manager.js:23
        throw new Error(`No lockfile was found in your project (one of ${paths
        ^

Error: No lockfile was found in your project (one of package-lock.json, yarn.lock, pnpm-lock.yaml). Install dependencies using your favorite manager!
    at getPackageManager (/Users/skyezer/Projects/my-cool-project/node_modules/@remotion/bundler/dist/get-package-manager.js:23:15)
    at Timeout._onTimeout (/Users/skyezer/Projects/my-cool-project/node_modules/@remotion/bundler/dist/update-available.js:30:77)
    at listOnTimeout (node:internal/timers:557:17)
    at processTimers (node:internal/timers:500:7)

I am running yarn workspaces with a root project, a frontend editor, and the video package.

Details

  • OS: macOS 11.6.2
  • Node: v16.16.1
  • Remotion: remotion@2.6.5
  • Yarn: v1.22.17

From the stack above, the culprit is get-package-manager.ts at tag v2.6.5. I've checked the main branch and this code has been modified to return "unknown" when it fails to find a package manager, but remains a problem in the latest release in NPM.

Would it be worth making this code recursive so it can correctly find the workspace root in multi-package projects? I'd be happy to do a PR for that, although I'm not aware of any side effects it might cause!

@kaylendog kaylendog added the bug Something isn't working label Jan 28, 2022
@kaylendog
Copy link
Contributor Author

kaylendog commented Jan 28, 2022

I have created PR #806 that should fix this issue.

@kaylendog
Copy link
Contributor Author

Fixed by #803

@JonnyBurger
Copy link
Member

JonnyBurger commented Jan 28, 2022

Fix is now released in 2.6.6. Thanks again 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants