Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Fully Static Comments #3

Open
remusao opened this issue Nov 19, 2017 · 11 comments
Open

Comments: Fully Static Comments #3

remusao opened this issue Nov 19, 2017 · 11 comments

Comments

@remusao
Copy link
Owner

remusao commented Nov 19, 2017

Comments for https://remusao.github.io/posts/static-comments.html

@remusao
Copy link
Owner Author

remusao commented Nov 19, 2017

Comments are hosted on github. Each post has its own issue.

@remusao
Copy link
Owner Author

remusao commented Nov 19, 2017

It's possible to use specific syntax from Github Markdown as well:

  • item1
  • item2
  • item3

@remusao
Copy link
Owner Author

remusao commented Nov 19, 2017

A bit of code? Sure...

function main() {
  console.log("Hello World!");
}

@chrmod
Copy link

chrmod commented Nov 19, 2017

That's a really neat idea. Aside of running comments on github infrastructure, it makes them visible on github profile pages https://github.com/remusao?tab=overview&from=2017-11-19 - which makes them discoverable through that channel!

wonder how this play out with github TOS. probably people considered to use github as on scale publishing platform, but does github put a limit on such usage?

@chrmod
Copy link

chrmod commented Nov 19, 2017

update to previous comment: it seems commenting on github issues is not counted as contributing to repository so is not published at github profile pages. at least I cannot see my comment there: https://github.com/chrmod?tab=overview&from=2017-11-19

@remusao
Copy link
Owner Author

remusao commented Nov 19, 2017

@chrmod Thanks! It's also nice to mention other people, and get notifications when answers are posted!

@sbdzdz
Copy link

sbdzdz commented Nov 21, 2017

Pretty cool! I might use something similar on my Jekyll blog once I post anything to comment on.

You can consider styling the timestamp a bit and making the usernames clickable, like here.

I also thought about using 👍 and 👎 as a voting system :)

@remusao
Copy link
Owner Author

remusao commented Nov 21, 2017

Thanks @sebastiandziadzio!

All valid suggestions. It's still super basic but I will try to add more niceties soon:

  • Reactions
  • User's picture
  • Clickable name
  • etc.

I just felt that I had done too much HTML/CSS for a week-end! :D

@kaknut
Copy link

kaknut commented Apr 11, 2018

testing

@amcgregor
Copy link

amcgregor commented May 29, 2020

This is not a terrible idea at all; also interesting that your use of a <details> element is what triggered a user learning web development to ask how that was being done without JavaScript in an IRC channel I frequent.

Theoretically this could be implemented client-side without much (or any) third-party involvement beyond JS delivered from your domain with the page, and the XHR/Fetch issued to GitHub, given the repository is public. 😀 Potentially as a way to divorce externally generated content (other's voices) from the authoritative content (in your voice) that the page itself represents for indexers that don't perform complex JS. (At a cost of losing those contributions potential future contributions to your PageRank.)

Edited to add: It would also free up the comments from dependence on back-end static site deployments; they'd be "live", and potentially only requested on demand. ⚠️ Super-relevant recent update: A recent executive order impacting USA-based sites, may make you liable for third-party contributed content, now…

@remusao
Copy link
Owner Author

remusao commented May 29, 2020

Thank you for your feedback @amcgregor. I like your point about the comments being part of the HTML statically and how that relates to indexers. When I thought about this comment system, I had set myself as a goal to both remove the need for any JavaScript, and also keep very fast loading speed of pages. The trade-off I picked was a bit extreme... but I like it as a proof of concept! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants