Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a finer grained filter for charging level (power) #4

Closed
remuslazar opened this issue Dec 10, 2016 · 8 comments
Closed

Use a finer grained filter for charging level (power) #4

remuslazar opened this issue Dec 10, 2016 · 8 comments

Comments

@remuslazar
Copy link
Owner

Status Quo and Motivation

Currently there is only a binary switch on the filter pane "show only fast-charging". This filter should be finer-grained, so the user can also select e.g. available AC (16/32A) plugs but not "Schuko"

Technical Details

The used API distinguishes between 3 distinct "charging level" classes:

"ChargerTypes": [
    {
      "Comments": "Under 2 kW, usually domestic socket types",
      "Title": "Level 1 : Low (Under 2kW)"
    },
    {
      "Comments": "Over 2 kW, usually non-domestic socket type",
      "Title": "Level 2 : Medium (Over 2kW)"
    },
    {
      "Comments": "40KW and Higher",
      "Title": "Level 3:  High (Over 40kW)"
    }
  ],

The API only allows queries using a ChargerTypelist, so the filter should reflect this classification, showing e.g. a slider with 3 steps for the "minimum level". And because the ChargerType value is also being used for the pin colors, the new filter should also use the same colors to make the UX more intuitive and consistent.

Note: in Germany, regular "Schuko" connections, despite of having more than 2kW are also tagged as "Level 1".

Relates to #1

@secuder
Copy link

secuder commented Dec 11, 2016

even with settings set to "Schuko (Type F) OFF" the APP offers the loading point "Kulinario" in Schweinfurter Straße 7, 97525 Schwebheim, Germany.
Data base shows 2x 3kW Schuko and 0x several other plugs for this location, so this might be a problem with the database - maybe you are able to sort them out anyway.

@remuslazar
Copy link
Owner Author

@secuder the "0x" is definitely a bug in the OCM data, yes, the "count" property being optional it should have been null in the JSON having the semantic "number of connections unknown". Unfortunately the "0" means the same for the OCM logic, for that reason the filtered query also lists this entries.

@secuder
Copy link

secuder commented Dec 11, 2016

understood - it will be hard to improve the database at this point :-) but any possibility to filter that in the APP?
Not good, I know, but better than false readings

@remuslazar
Copy link
Owner Author

@secuder I can't workaround this issue, this has to be done in the OCM database layer.. I will try to open a bug request there..

@secuder
Copy link

secuder commented Dec 22, 2016

Hm, workaround does not work on build 12: Loading point "Kulinario" in Schweinfurter Straße 7, 97525 Schwebheim, Germany is still on display even with Schuko OFF.
(Data base shows 2x 3kW Schuko and 0x several other plugs for this location)

@remuslazar
Copy link
Owner Author

@secuder this is an issue with the OCM database. 0x means there often "we simply don't know how many plugs are available". So I can't just filter them out, this will be just wrong. It would have been better to save a null instead of the int 0, but ..

@secuder
Copy link

secuder commented Dec 22, 2016

I see, but what kind of workaround have you implemented then?

@remuslazar
Copy link
Owner Author

my comment is just wrong, I will delete it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants