-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiling doesn't seem to work on node v12? #1
Comments
Doesn't seem to work on v10 either:
|
Sorry,I just test it on node 8, and it works. I'll try fix it soon. |
@sontek you can try node-pdfium@1.0.4 |
Nice! It actually installed properly on node but when I try to rebuild it against the version electron uses I get this:
|
@sontek electron 5.0 correspond to node 12... And I should take a while to make it compatible with node 12 |
I'm willing to pay for your time to get it fixed up and working. I'm currently shelling out to Foxit PDF Reader to print and I'd love to do something in process :P |
@sontek you can try 2.0 |
Compiles on v12 =) Currently getting this error:
with this code:
when I list the printers I get:
|
@renaesop Is my error because the arguments don't line up in the same order here? Lines 3 to 14 in 00cfaac
|
Also, is there a way to just use the printer settings rather than passing width/height/dpi and all that? |
Documentation was just wrong, this works:
So the only thing I'd like now is the ability to use printer settings so my app doesn't have to be customized. They can define page size and all that on the printer itself. |
I also ran into issues running our app on OSX. You currently block anything but windows, is there a reason for that? |
Can you release a new version where you define you only work on windows so I can mark you as an optional dependency |
Document has been fixed. If you’d like to get printer settings, you can use the package “printer”. Emmm... if you leave the page size away, it’ll use PDF’s intrinsic width and height. |
POSIX operating system use CUPS to print, and it supports PDF natively. So, only windows needs a library for printing PDF. |
@renaesop The one that was giving me issues was |
@renaesop Do you have a preferred library you use on mac that interacts with CUPS from node.js? |
Windows gdi print api demands width/height in pixel, so the printer dpi is required. If you want to get printer’s dpi, you can use the package “printer”. Also, package “printer” provides a printFile — you can use it to print pdf on CUPS |
@renaesop Yeah, I just
|
@renaesop I think my point is that your library is the closest to a functional PDF printing library in the node.js community right now and since |
@sontek ok, I'll try |
The text was updated successfully, but these errors were encountered: