-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin inject wrong config file #5
Comments
Hello! If the command is running in docker then should be used the dockered path. To avoid this problem I recomend to use the Sorry, but I didn't understand the problem. Did you mean that WSL path of phpunit.xml should be converted to the dockered path? |
Yes. This extension generates this error: spawn docker exec -it 833f9 bash -c "var/www/html/vendor/bin/phpunit -c /home/user13/code/phpunit.xml" ENOENT
|
I think it shouldn't add phpunit.xml if you didn't specify the phpunit.xml path in config file. Do you agree? |
Yes. I don't think it shoud add it. Maybe you could add a config option. EG. "phpunit.config_file": "/home/user13/code/phpunit.xml"
|
Yes, I think it's the best way. I'll change the code soon with this bugfix. |
I'm not sure how to apply and test this changes. |
I'll launch a new version (1.0.2) and if it includes new bugs, please, tell me, because I tested but I needed more person testing 😄 |
Thank you for the update. Given the following config: "phpunit.relativeFilePath": true,
"phpunit.phpunit": "/var/www/html/vendor/bin/phpunit",
"phpunit.docker": true,
"phpunit.dockerImage": "docker exec -it e1066", It generates the following error: 2 things:
❌ |
Sorry for the late response but I'm very busy. When I'll be free I'll see these cases. |
I think there're 2 points in your error: 1 - If |
Sorry for the late response. The main project has been updated. I think we should try it because there are more features. :D |
I have a DDEV project I run in Remote WSL session.
If I configure this plugin to run with the following settings
I get the following error:
The following is successful
docker exec -it 833f9 "/var/www/html/vendor/bin/phpunit"
I do not understand why
-c /home/user13/code/phpunit.xml
is being injected.This config file is my WSL path. If the command is running in docker, then it should be the dockered path?
I check the actual path:
I can run the following in my terminal:
docker exec -it 833f9 bash -c "/var/www/html/vendor/bin/phpunit -c /var/www/html/phpunit.xml"
So I think the correct spawn command should be:
spawn docker exec -it 833f9 bash -c "/var/www/html/vendor/bin/phpunit -c /var/www/html/phpunit.xml"
spawn docker exec -it 833f9 bash -c "/var/www/html/vendor/bin/phpunit -c /home/user13/code/phpunit.xml"
VSCode 1.66.2
renandelmonico.vscode-php-test-explorer 1.0.1
The text was updated successfully, but these errors were encountered: