Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

W0001 triggering incorrectly #8

Open
ScreamingHawk opened this issue May 28, 2019 · 2 comments
Open

W0001 triggering incorrectly #8

ScreamingHawk opened this issue May 28, 2019 · 2 comments

Comments

@ScreamingHawk
Copy link

List<User> users = [select Id, Email, IsActive from User where Id not in :ignoreIds];

returns the error: W0001 at 19: SOQL query with more than one condition and/or field being searched should be splitted into multiple lines.

^ Also there is a grammatical mistake in the error wording.

I'm really excited for this project but see it hasn't been touched in a while. Are you happy to accept pull requests on this repo?

@renatoliveira
Copy link
Owner

Hi there! I'm glad that you found this project useful.

I started this small project to try to automate some parts of code reviewing, but after searching for a while, I noticed that I might have been approaching the problem the wrong way. When I searched the web I found that it might be better to read about tokenization and whatever else modern linters actually use to split the code and analyze it. That's why it hasn't been touched in a while (no time and almost no resources on this, and the lack of time is a big player here as well).

That said: I'll accept PRs, sure. But I wouldn't expect new contributions coming from myself anytime soon. I might get back to it in the future, though...

@ScreamingHawk
Copy link
Author

No prob. I've got a couple projects in the same place. Technical debt and time are huge blockers to progress. If I end up making improvements I'll push them back here 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants