Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reloading support #4

Closed
renchap opened this issue Jan 31, 2017 · 1 comment
Closed

Hot reloading support #4

renchap opened this issue Jan 31, 2017 · 1 comment
Labels

Comments

@renchap
Copy link
Owner

renchap commented Jan 31, 2017

Hot Reloading of React code is very powerful when done correctly, and we should support it.

The best way to do so seems to be React-Hot-Reloader version 3, currently not released : gaearon/react-hot-loader#240
Gaearon's take on why it is not yet released : gaearon/react-hot-boilerplate#97
TL;DR: is is often misused and badly integrated, thus people end up with bad production builds. He is now working on bringing hot reloading directly into React.

With rails/webpacker#55 the first step for the support has been done, now we need to document how to enable hot reloading (mostly changes to Webpack config and the root component). An idea would be to include the boilerplate to enable hot reloading into our JS code : we render the HR components, then call the app root component in them, so the user does not need to change its code to use hot reloading, only enable it in an initializer or a react_component call.

@renchap
Copy link
Owner Author

renchap commented Feb 23, 2017

Implemented by #7

@renchap renchap closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant