Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for remapping modifier keys #576

Open
jespertheend opened this issue Apr 20, 2023 · 3 comments
Open

Support for remapping modifier keys #576

jespertheend opened this issue Apr 20, 2023 · 3 comments
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Shortcuts Related to shortcut commands, or the logic behind firing them.
Milestone
backlog

Comments

@jespertheend
Copy link
Collaborator

jespertheend commented Apr 20, 2023 •
edited

On linux I have xmodmap configured to swap control and command, all applications respect this preference, but chrome for some reason browsers still report this key as 'ControlLeft' and 'OSLeft'. It seems like the ctrlKey and metaKey properties on keyboard events do respect this preference though, so those should probably be used instead.
@jespertheend jespertheend added effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Shortcuts Related to shortcut commands, or the logic behind firing them. labels Apr 20, 2023
@jespertheend jespertheend added this to the backlog milestone Apr 20, 2023
@jespertheend jespertheend mentioned this issue Apr 20, 2023
Closed
@jespertheend
Copy link
Collaborator Author

Interesting to note: Firefox does not seem to set metaKey to true on linux, it does on OS X.

@jespertheend
Copy link
Collaborator Author

jespertheend commented Apr 29, 2023 •
edited

modifier keys, and xmodmap in general is a big mess. See https://crbug.com/1076544
I don't think this is a bug in Renda Studio, but rather, a bug in browsers.
I think the best solution here is to allow users to configure their modifier keys using preferences.
We can't expect the user to remap all shortcuts containing the Ctrl key for instance.

@jespertheend jespertheend changed the title Better handling of Control and Command keyboard shortcuts based on the platform Support for remapping modifier keys Apr 29, 2023
@jespertheend
Copy link
Collaborator Author

Fwiw, keyd seems like a good replacement for xmodmap that does not run into this issue.
See https://superuser.com/a/1790598/594545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Shortcuts Related to shortcut commands, or the logic behind firing them.
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
1 participant
@jespertheend