Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendora stops working when headless chrome restarted #6

Open
rjyo opened this issue Dec 19, 2018 · 2 comments
Open

Rendora stops working when headless chrome restarted #6

rjyo opened this issue Dec 19, 2018 · 2 comments

Comments

@rjyo
Copy link

rjyo commented Dec 19, 2018

When the headless chrome is restarted, rendora will not able to render anymore.

Restart rendora will get this fixed.

@geokb
Copy link
Member

geokb commented Dec 19, 2018

While you definitely shouldn't intentionally restart or exit the headless Chrome instance while rendora is working, I agree there should be some way to check the liveness and support automatic reconnections that can be especially useful for failed and restarted headless chrome docker containers. The problem is that chrome-devtools-protocols works basically over websockets and the headless chrome listen websocket url changes every time Chrome is restarted since it contains a UUID.

I suggest we check the liveness every short interval through the endpoint "/json/version", compare the debugging ws urls and renew the ws connection if it is not the same. This might cause unintentional problems with service discovery setups (i.e. the DNS resolution could route you to a different container after each restart).

Since you mentioned puppeteer in the other issue, do you know how is this situation handled there if it's handled at all?

@rjyo
Copy link
Author

rjyo commented Dec 21, 2018

Thanks for the reply.

Haven't try puppeteer in this case.

As we had previously used headless Chrome and had an experience that we had to restart the Chrome periodically to make it stable enough, making rendora usable after the headless Chrome got restarted would be important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants