Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiV_CoreTimer Added Reload for OneShot Mode #528

Closed
Eoin-Dickson opened this issue Oct 10, 2023 · 1 comment
Closed

MiV_CoreTimer Added Reload for OneShot Mode #528

Eoin-Dickson opened this issue Oct 10, 2023 · 1 comment

Comments

@Eoin-Dickson
Copy link

Description

MiV_CoreTimer has two modes One-shot and Continuous. When operating in One-shot mode the timer should count down from its initial value and stop. When given an initial value it should reload meaning it should restart counting down from the given number. Currently it will not start counting down for a second time after being set with an initial value.

Expected behaviour

Once the initial timer cycle is completed, an initial value is assigned to the timer. The timer then verifies if it is set in One-shot mode. If One-shot mode is enabled, the timer initiates the countdown from the specified initial value

How to reproduce?

I have tested using examples from the MiV Repo and when the time is started and supplied with a new timer value it does not restart.

Environment

Windows
Renode 1.14.0

Do you plan to address this issue and file a PR?

Yes, I will create a PR for this issue

@Eoin-Dickson
Copy link
Author

We have tested this change and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant