This repository has been archived by the owner on Nov 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Add global tool wrapper #163
Labels
enhancement
New feature or request
Comments
This would also allow doing |
So for each tool Would the wrapper locate the real |
the wrapper sources our env, after it the wrapper will be later in path so it simply calls the real x then. thats how it currently works for |
Missing parts:
|
5 tasks
This comment has been minimized.
This comment has been minimized.
Duplicate of containerbase/base#21 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What to do
To have better compability with other workflows we should add global wrapper for installed tools.
Those wrapper should source
BASH_ENV
and then call normal tool, so we have our prepared env loaded.Sample Jenkins
docker run ... -d --rm renovatebot/node cat
/path/to/run.sh
shell script with commands at shared dir.docker exec <container-id> sh /path/to/run.sh
The exec is calling default
sh
command in env, which will be linked todash
on our ubuntu image.Overwriting it to
bash
won't help, as it won't sourceBASH_ENV
.exec
is also not calling entrypoint, so again noBASH_ENV
sourcing.Solution
creating shell wrapper like we did for node < 15
docker-buildpack/src/node/buildpack/tools/node.sh
Lines 39 to 42 in 7fe5151
docker-buildpack/src/base/buildpack/util.sh
Lines 56 to 76 in 97680db
The text was updated successfully, but these errors were encountered: