Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sign images using cosign #261

Merged
merged 4 commits into from Dec 29, 2021
Merged

feat: sign images using cosign #261

merged 4 commits into from Dec 29, 2021

Conversation

JamieMagee
Copy link
Collaborator

@JamieMagee JamieMagee commented Dec 28, 2021

Signs all images automatically using cosign keyless workflow. Tested on my own fork of containerbase/python1 (The build log contains some additional logging not present in this PR)

This requires cosign to be installed in all workflows where container images are published, but the sigstore team provides an action to do this2, and I've opened an issue to have it be included in GitHub Actions workers by default 3

Closes containerbase/base#201

References:

Related PRs:

Footnotes

  1. https://github.com/JamieMagee/python/runs/4646250456?check_suite_focus=true

  2. https://github.com/sigstore/cosign-installer

  3. https://github.com/actions/virtual-environments/issues/4813

viceice pushed a commit to containerbase/php that referenced this pull request Dec 28, 2021
viceice pushed a commit to containerbase/java that referenced this pull request Dec 28, 2021
viceice pushed a commit to containerbase/node that referenced this pull request Dec 28, 2021
JamieMagee added a commit to renovatebot/docker-sidecar that referenced this pull request Dec 28, 2021
viceice added a commit to containerbase/python that referenced this pull request Dec 28, 2021
See containerbase/internal-tools#261

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice added a commit to containerbase/ruby that referenced this pull request Dec 28, 2021
See containerbase/internal-tools#261

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice pushed a commit to containerbase/sidecar that referenced this pull request Dec 28, 2021
viceice pushed a commit to renovatebot/docker-renovate that referenced this pull request Dec 28, 2021
viceice pushed a commit to renovatebot/docker-rust that referenced this pull request Dec 28, 2021
viceice pushed a commit to renovatebot/docker-sidecar that referenced this pull request Dec 28, 2021
JamieMagee added a commit to renovatebot/docker-dotnet that referenced this pull request Dec 28, 2021
JamieMagee added a commit to renovatebot/docker-helm that referenced this pull request Dec 28, 2021
viceice pushed a commit to renovatebot/docker-node that referenced this pull request Dec 28, 2021
viceice pushed a commit to renovatebot/docker-elixir that referenced this pull request Dec 28, 2021
viceice pushed a commit to renovatebot/docker-dotnet that referenced this pull request Dec 28, 2021
JamieMagee added a commit to renovatebot/docker-swift that referenced this pull request Dec 28, 2021
viceice pushed a commit to renovatebot/docker-helm that referenced this pull request Dec 28, 2021
viceice pushed a commit to renovatebot/docker-go that referenced this pull request Dec 28, 2021
viceice pushed a commit to renovatebot/docker-swift that referenced this pull request Dec 28, 2021
viceice added a commit to renovatebot/docker-ruby that referenced this pull request Dec 28, 2021
See containerbase/internal-tools#261

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice pushed a commit to renovatebot/docker-cocoapods that referenced this pull request Dec 28, 2021
viceice added a commit to renovatebot/docker-php that referenced this pull request Dec 28, 2021
* ci: install sigstore

  See containerbase/internal-tools#261

* Update .github/workflows/build.yml

* Update .github/workflows/build.yml

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice added a commit to renovatebot/docker-java that referenced this pull request Dec 28, 2021
See containerbase/internal-tools#261

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice added a commit to renovatebot/docker-python that referenced this pull request Dec 28, 2021
See containerbase/internal-tools#261

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice pushed a commit to renovatebot/docker-renovate-full that referenced this pull request Dec 28, 2021
src/utils/cosign/common.ts Outdated Show resolved Hide resolved
test/utils/cosign/common.spec.ts Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice viceice merged commit 44ac477 into containerbase:main Dec 29, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign container images
2 participants