fix(helm): handle undefined repository

renovatebot · Oct 17, 2019 · 3eede6a · 3eede6a
1 parent 696f3ec
commit 3eede6a
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 11 deletions.
diff --git a/lib/manager/helm-requirements/extract.ts b/lib/manager/helm-requirements/extract.ts
@@ -46,20 +46,24 @@ export async function extractPackageFile(
     const res: PackageDependency = {
       depName: dep.name,
       currentValue: dep.version,
-      registryUrls: [dep.repository],
     };
-    if (dep.repository.startsWith('@')) {
-      res.skipReason = 'placeholder-url';
-    } else {
-      try {
-        const url = new URL(dep.repository);
-        if (url.protocol === 'file:') {
-          res.skipReason = 'local-dependency';
+    if (dep.repository) {
+      res.registryUrls = [dep.repository];
+      if (dep.repository.startsWith('@')) {
+        res.skipReason = 'placeholder-url';
+      } else {
+        try {
+          const url = new URL(dep.repository);
+          if (url.protocol === 'file:') {
+            res.skipReason = 'local-dependency';
+          }
+        } catch (err) {
+          logger.debug({ err }, 'Error parsing url');
+          res.skipReason = 'invalid-url';
         }
-      } catch (err) {
-        logger.debug({ err }, 'Error parsing url');
-        res.skipReason = 'invalid-url';
       }
+    } else {
+      res.skipReason = 'no-repository';
     }
     return res;
   });

diff --git a/test/manager/helm-requirements/__snapshots__/extract.spec.ts.snap b/test/manager/helm-requirements/__snapshots__/extract.spec.ts.snap
@@ -42,6 +42,11 @@ Object {
       ],
       "skipReason": "invalid-url",
     },
+    Object {
+      "currentValue": "0.8.1",
+      "depName": "broken",
+      "skipReason": "no-repository",
+    },
   ],
 }
 `;

diff --git a/test/manager/helm-requirements/extract.spec.ts b/test/manager/helm-requirements/extract.spec.ts
@@ -24,6 +24,8 @@ describe('lib/manager/helm/extract', () => {
         - name: postgresql
           version: 0.8.1
           repository: nope
+        - name: broken
+          version: 0.8.1
       `;
       const fileName = 'requirements.yaml';
       const result = await extractPackageFile(content, fileName);