fix: handle parsing of invalid YAML in .travis.yml (#4191)

renovatebot · Jul 27, 2019 · a6b48f6 · a6b48f6
1 parent 9e5ea71
commit a6b48f6
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/lib/manager/travis/extract.ts b/lib/manager/travis/extract.ts
@@ -1,9 +1,16 @@
 import is from '@sindresorhus/is';
 import yaml from 'js-yaml';
 import { PackageFile, PackageDependency } from '../common';
+import { logger } from '../../logger';
 
 export function extractPackageFile(content: string): PackageFile {
-  const doc = yaml.safeLoad(content);
+  let doc;
+  try {
+    doc = yaml.safeLoad(content);
+  } catch (err) {
+    logger.warn({ err, content }, 'Failed to parse .travis.yml file.');
+    return null;
+  }
   let deps: PackageDependency[] = [];
   if (doc && is.array(doc.node_js)) {
     deps = [

diff --git a/test/manager/travis/_fixtures/invalid.yml b/test/manager/travis/_fixtures/invalid.yml
@@ -0,0 +1,2 @@
+after_deploy:
+  - "curl -H 'Content-Type: application/json' --data '{\'build\': true}' -X POST $DOCKER_HUB_URL;"
diff --git a/test/manager/travis/extract.spec.ts b/test/manager/travis/extract.spec.ts
@@ -1,5 +1,12 @@
+import { readFileSync } from 'fs';
+import { resolve } from 'path';
 import { extractPackageFile } from '../../../lib/manager/travis/extract';
 
+const invalidYAML = readFileSync(
+  resolve('test/manager/travis/_fixtures/invalid.yml'),
+  'utf8'
+);
+
 describe('lib/manager/travis/extract', () => {
   describe('extractPackageFile()', () => {
     it('returns empty if fails to parse', () => {
@@ -11,5 +18,9 @@ describe('lib/manager/travis/extract', () => {
       expect(res).toMatchSnapshot();
       expect(res.deps).toHaveLength(1);
     });
+    it('should handle invalid YAML', () => {
+      const res = extractPackageFile(invalidYAML);
+      expect(res).toBeNull();
+    });
   });
 });