Rebasing incredibly slow #11866

TheDutchCoder · 2021-09-23T15:25:13Z

TheDutchCoder
Sep 23, 2021

I've raised this issue before, but I'm not sure if I'm doing something wrong.

Whatever I try, I simply can't get renovate to communicate it's rebasing a PR.
Checking the checkbox does nothing. I've waited 15 minutes and it just doesn't do anything. Then after about ~25 minutes it does the rebase, an incredibly long time.

TheDutchCoder · 2021-09-23T15:30:21Z

TheDutchCoder
Sep 23, 2021
Author

Okay, it took 33 minutes for it to trigger, that seems excessive.
Is there maybe a way to show on the PR that a rebase is "scheduled", right now there's no feedback whatsoever and people coming from dependabot (like myself), are probably used to direct feedback.

2 replies

rarkins Sep 23, 2021
Maintainer

How are you running Renovate, and on what platform?

Edit: looks like github.com hosted app, but will leave this here just to confirm

TheDutchCoder Sep 23, 2021
Author

Yes it's the github.com hosted app.

rarkins · 2021-09-23T15:33:55Z

rarkins
Sep 23, 2021
Maintainer

Runs should be triggered near instantly when the checkbox is ticked

15 replies

viceice Sep 23, 2021
Maintainer

Renovate will use that to update the npm lockfile. It seems you have a lot deps. So the lockfile update needs too much time.

@rarkins any ideas to dig deeper into it?

rarkins Sep 23, 2021
Maintainer

If it's rebasing 20 branches per run then that's ~1 minute or so per lock file - not too bad if it's a large monorepo

TheDutchCoder Sep 23, 2021
Author

We don't commit to develop a whole lot on a "per hour" basis, I'd say we merge into develop a couple of times a day max.
I can remove automerge, because that doesn't work with reviewers/code-owners anyway, but not sure if that would have any impact.

Again, all I can see is quite a lot of docker spin ups, all taking quite a significant amount of time, resulting in a very, very long process.

I don't know how renovate differs from something like dependabot, I can only give you my end-user experience, but dependabot seemed to always do thing instantaneously, but that might also be because it didn't group PR's for example.

rarkins Sep 24, 2021
Maintainer

It's somewhat of an apples and oranges comparison. Dependabot supports neither grouping, automerging, or automatic rebasing of out of date branches. It is these features most likely causing the high run time.

The reality is that if a tool like Renovate requires you to keep manually requesting rebases, it's not very efficient for you. The problem is you have too many concurrent branches which appear to be rebasing themselves each run. Solutions:

Decrease the concurrent branch limit (note: this won't go and delete any existing, so won't have an effect until you either merge or close existing ones manually)
Remove automerge and/or automatic rebasing (set rebaseWhen=conflicted). However if you have branch protection saying PRs must be up to date then it's not ideal to remove automatic rebasing

TheDutchCoder Sep 24, 2021
Author

Ah okay I see, you guys rebase on every merge to the branch, whereas dependabot only does that in cases of conflicts (or when asked for manually).

I like your approach better, so I will play with the concurrent branch limit a bit.

Just as an aside: even when nothing is currently running and I ask for a rebase with the checkbox, it takes 6 minutes or so before I see anything happening. Is there a way for renovate to (for example how dependabot does it) indicate a PR is queued? Currently you just have to trust things are being processed, whereas dependabot alters the PR body to show that it's currently rebasing and that it might take a while.

Just a better UX basically.

TheDutchCoder · 2021-09-23T15:46:55Z

TheDutchCoder
Sep 23, 2021
Author

Right now I'm getting the following issue in the dashboard:

INFO log

INFO: Repository started
{
  "renovateVersion": "27.18.0"
}
INFO: Dependency extraction complete
{
  "baseBranch": "develop",
  "stats": {
    "managers": {
      "npm": {
        "fileCount": 69,
        "depCount": 454
      }
    },
    "total": {
      "fileCount": 69,
      "depCount": 454
    }
  }
}
INFO: Branch updated(branch="renovate/amplify")
{
  "commitSha": "8d8af029"
}
INFO: Branch updated(branch="renovate/chalk-a11y")
{
  "commitSha": "d20520d4"
}
INFO: PR updated(branch="renovate/chalk-a11y")
{
  "pr": 2067,
  "prTitle": "chore(deps): update chalk-a11y to v3.2.16"
}
INFO: Branch updated(branch="renovate/chalk-icons")
{
  "commitSha": "c621ed04"
}
INFO: PR updated(branch="renovate/chalk-icons")
{
  "pr": 2071,
  "prTitle": "chore(deps): update dependency vue to v3.2.16"
}
INFO: Branch updated(branch="renovate/graph-api")
{
  "commitSha": "3ac5de17"
}
INFO: Branch updated(branch="renovate/lambda-core")
{
  "commitSha": "67e0d91b"
}
INFO: PR created(branch="renovate/proofflow")
{
  "pr": 2073,
  "prTitle": "chore(deps): update proofflow to v3.2.16"
}
INFO: Branch updated(branch="renovate/sam")
{
  "commitSha": "64140eac"
}
ERROR: Error generating branch cache
{
  "err": {
    "hostType": "github",
    "err": {
      "name": "HTTPError",
      "timings": {
        "start": 1632411863119,
        "socket": 1632411863119,
        "lookup": 1632411863119,
        "connect": 1632411863128,
        "secureConnect": 1632411863137,
        "upload": 1632411863137,
        "response": 1632411863238,
        "end": 1632411863240,
        "phases": {
          "wait": 0,
          "dns": 0,
          "tcp": 9,
          "tls": 9,
          "request": 0,
          "firstByte": 101,
          "download": 2,
          "total": 121
        }
      },
      "message": "Response code 401 (Unauthorized)",
      "stack": "HTTPError: Response code 401 (Unauthorized)\n    at Request. (/home/ubuntu/renovateapp/node_modules/renovate/node_modules/got/dist/source/as-promise/index.js:117:42)\n    at runMicrotasks ()\n    at processTicksAndRejections (internal/process/task_queues.js:95:5)",
      "options": {
        "headers": {
          "user-agent": "Renovate Bot (GitHub App 2740)",
          "accept": "application/vnd.github.machine-man-preview+json",
          "authorization": "***********",
          "accept-encoding": "gzip, deflate, br"
        },
        "url": "https://api.github.com/repos/creativelayer/creativelayer/pulls/2073",
        "hostType": "github",
        "username": "",
        "password": "",
        "method": "GET",
        "http2": false
      },
      "response": {
        "statusCode": 401,
        "statusMessage": "Unauthorized",
        "body": {
          "message": "Bad credentials",
          "documentation_url": "https://docs.github.com/rest"
        },
        "headers": {
          "server": "GitHub.com",
          "date": "Thu, 23 Sep 2021 15:44:23 GMT",
          "content-type": "application/json; charset=utf-8",
          "content-length": "80",
          "x-github-media-type": "github.v3; param=machine-man-preview; format=json",
          "x-ratelimit-limit": "60",
          "x-ratelimit-remaining": "55",
          "x-ratelimit-reset": "1632412237",
          "x-ratelimit-used": "5",
          "x-ratelimit-resource": "core",
          "access-control-expose-headers": "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset",
          "access-control-allow-origin": "*",
          "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
          "x-frame-options": "deny",
          "x-content-type-options": "nosniff",
          "x-xss-protection": "0",
          "referrer-policy": "origin-when-cross-origin, strict-origin-when-cross-origin",
          "content-security-policy": "default-src 'none'",
          "vary": "Accept-Encoding, Accept, X-Requested-With",
          "x-github-request-id": "9844:7A92:5B033C:635C08:614CA0D7",
          "connection": "close"
        },
        "httpVersion": "1.1"
      }
    },
    "message": "external-host-error",
    "stack": "Error: external-host-error\n    at handleGotError (/home/ubuntu/renovateapp/node_modules/renovate/dist/util/http/github.js:69:19)\n    at GithubHttp.request (/home/ubuntu/renovateapp/node_modules/renovate/dist/util/http/github.js:161:13)\n    at runMicrotasks ()\n    at processTicksAndRejections (internal/process/task_queues.js:95:5)\n    at async GithubHttp.requestJson (/home/ubuntu/renovateapp/node_modules/renovate/dist/util/http/index.js:176:21)\n    at async getPr (/home/ubuntu/renovateapp/node_modules/renovate/dist/platform/github/index.js:517:17)\n    at async Proxy.getBranchPr (/home/ubuntu/renovateapp/node_modules/renovate/dist/platform/github/index.js:619:40)\n    at async generateBranchCache (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/cache.js:32:30)\n    at async setBranchCache (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/cache.js:73:26)\n    at async Object.renovateRepository (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/index.js:71:9)\n    at async renovateRepository (/home/ubuntu/renovateapp/app/worker/index.js:400:26)\n    at async /home/ubuntu/renovateapp/app/worker/index.js:644:5"
  },
  "branchName": "renovate/proofflow"
}
WARN: Could not ensure issue
{
  "err": {
    "hostType": "github",
    "err": {
      "name": "HTTPError",
      "timings": {
        "start": 1632411863331,
        "socket": 1632411863331,
        "lookup": 1632411863340,
        "connect": 1632411863348,
        "secureConnect": 1632411863359,
        "upload": 1632411863359,
        "response": 1632411863467,
        "end": 1632411863467,
        "phases": {
          "wait": 0,
          "dns": 9,
          "tcp": 8,
          "tls": 11,
          "request": 0,
          "firstByte": 108,
          "download": 0,
          "total": 136
        }
      },
      "message": "Response code 401 (Unauthorized)",
      "stack": "HTTPError: Response code 401 (Unauthorized)\n    at Request. (/home/ubuntu/renovateapp/node_modules/renovate/node_modules/got/dist/source/as-promise/index.js:117:42)\n    at runMicrotasks ()\n    at processTicksAndRejections (internal/process/task_queues.js:95:5)",
      "options": {
        "headers": {
          "user-agent": "Renovate Bot (GitHub App 2740)",
          "accept": "application/vnd.github.machine-man-preview+json",
          "authorization": "***********",
          "content-type": "application/json",
          "content-length": "2807",
          "accept-encoding": "gzip, deflate, br"
        },
        "url": "https://api.github.com/repos/creativelayer/creativelayer/issues",
        "hostType": "github",
        "username": "",
        "password": "",
        "method": "POST",
        "http2": false
      },
      "response": {
        "statusCode": 401,
        "statusMessage": "Unauthorized",
        "body": {
          "message": "Bad credentials",
          "documentation_url": "https://docs.github.com/rest"
        },
        "headers": {
          "server": "GitHub.com",
          "date": "Thu, 23 Sep 2021 15:44:23 GMT",
          "content-type": "application/json; charset=utf-8",
          "content-length": "80",
          "x-github-media-type": "github.v3; param=machine-man-preview; format=json",
          "x-ratelimit-limit": "60",
          "x-ratelimit-remaining": "54",
          "x-ratelimit-reset": "1632412237",
          "x-ratelimit-used": "6",
          "x-ratelimit-resource": "core",
          "access-control-expose-headers": "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset",
          "access-control-allow-origin": "*",
          "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
          "x-frame-options": "deny",
          "x-content-type-options": "nosniff",
          "x-xss-protection": "0",
          "referrer-policy": "origin-when-cross-origin, strict-origin-when-cross-origin",
          "content-security-policy": "default-src 'none'",
          "vary": "Accept-Encoding, Accept, X-Requested-With",
          "x-github-request-id": "9846:837A:678898:745741:614CA0D7",
          "connection": "close"
        },
        "httpVersion": "1.1"
      }
    },
    "message": "external-host-error",
    "stack": "Error: external-host-error\n    at handleGotError (/home/ubuntu/renovateapp/node_modules/renovate/dist/util/http/github.js:69:19)\n    at GithubHttp.request (/home/ubuntu/renovateapp/node_modules/renovate/dist/util/http/github.js:161:13)\n    at runMicrotasks ()\n    at processTicksAndRejections (internal/process/task_queues.js:95:5)\n    at async GithubHttp.requestJson (/home/ubuntu/renovateapp/node_modules/renovate/dist/util/http/index.js:176:21)\n    at async Proxy.ensureIssue (/home/ubuntu/renovateapp/node_modules/renovate/dist/platform/github/index.js:921:9)\n    at async ensureDependencyDashboard (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/dependency-dashboard.js:282:9)\n    at async Object.renovateRepository (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/index.js:81:13)\n    at async renovateRepository (/home/ubuntu/renovateapp/app/worker/index.js:400:26)\n    at async /home/ubuntu/renovateapp/app/worker/index.js:644:5"
  }
}
INFO: Repository finished
{
  "durationMs": 1799770
}

1 reply

rarkins Sep 23, 2021
Maintainer

I don't know the cause, but that log indicates that a valid token is not being used. The auth limit is 60.

TheDutchCoder · 2021-09-23T16:16:45Z

TheDutchCoder
Sep 23, 2021
Author

Let me also post our config, in case that might be useful:

Renovate Config

{
  "extends": [
    "config:base"
  ],
  "hostRules": [
    {
      "matchHost": "https://npm.pkg.github.com/",
      "hostType": "npm",
      "encrypted": {
        "token": "TOKEN_HERE"
      }
    }
  ],
  "npmrc": "@creativelayer:registry=https://npm.pkg.github.com",
  "includePaths": [ "amplify/**", "sam/**", "apps/**", "packages/**", "workflow" ],
  "labels": ["dependencies"],
  "packageRules": [
    {
      "matchPackagePatterns": [ "*" ],
      "matchPaths": [ "amplify/**/package.json" ],
      "groupName": "amplify",
      "automerge": true
    },
    {
      "matchPackagePatterns": [ "*" ],
      "matchPaths": [ "sam/**/package.json" ],
      "groupName": "sam",
      "automerge": true
    },
    {
      "matchPackagePatterns": [ "*" ],
      "matchPaths": [ "apps/proofflow/package.json" ],
      "groupName": "proofflow",
      "addLabels": ["proofflow"],
      "ignoreDeps": ["jest", "babel-jest", "babel-preset-jest", "ts-jest"]
    },
    {
      "matchPackagePatterns": [ "*" ],
      "matchPaths": [ "workflow/package.json" ],
      "groupName": "workflow",
      "addLabels": ["workflow"],
      "ignoreDeps": ["jest", "babel-jest", "babel-preset-jest", "ts-jest"]
    },
    {
      "matchPackagePatterns": [ "*" ],
      "matchPaths": [ "packages/chalk-icons/package.json" ],
      "groupName": "chalk-icons",
      "automerge": true,
      "addLabels": ["chalk-icons"]
    },
    {
      "matchPackagePatterns": [ "*" ],
      "matchPaths": [ "packages/chalk-a11y/package.json" ],
      "groupName": "chalk-a11y",
      "automerge": true,
      "ignoreDeps": ["jest", "babel-jest", "babel-preset-jest", "ts-jest"]
    },
    {
      "matchPackagePatterns": [ "*" ],
      "matchPaths": [ "packages/chalk-ui/package.json" ],
      "groupName": "chalk-ui",
      "automerge": true,
      "addLabels": ["chalk-ui"],
      "ignoreDeps": ["jest", "babel-jest", "babel-preset-jest", "ts-jest"]
    },
    {
      "matchPackagePatterns": [ "*" ],
      "matchPaths": [ "packages/graph-api/package.json" ],
      "groupName": "graph-api",
      "automerge": true
    },
    {
      "matchPackagePatterns": [ "*" ],
      "matchPaths": [ "packages/lambda-core/package.json" ],
      "groupName": "lambda-core",
      "automerge": true
    }
  ]
}

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebasing incredibly slow #11866

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 4 comments 18 replies

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

Rebasing incredibly slow #11866

TheDutchCoder Sep 23, 2021

Replies: 4 comments · 18 replies

TheDutchCoder Sep 23, 2021 Author

rarkins Sep 23, 2021 Maintainer

TheDutchCoder Sep 23, 2021 Author

rarkins Sep 23, 2021 Maintainer

viceice Sep 23, 2021 Maintainer

rarkins Sep 23, 2021 Maintainer

TheDutchCoder Sep 23, 2021 Author

rarkins Sep 24, 2021 Maintainer

TheDutchCoder Sep 24, 2021 Author

TheDutchCoder Sep 23, 2021 Author

rarkins Sep 23, 2021 Maintainer

TheDutchCoder Sep 23, 2021 Author

TheDutchCoder
Sep 23, 2021

Replies: 4 comments 18 replies

TheDutchCoder
Sep 23, 2021
Author

rarkins Sep 23, 2021
Maintainer

TheDutchCoder Sep 23, 2021
Author

rarkins
Sep 23, 2021
Maintainer

viceice Sep 23, 2021
Maintainer

rarkins Sep 23, 2021
Maintainer

TheDutchCoder Sep 23, 2021
Author

rarkins Sep 24, 2021
Maintainer

TheDutchCoder Sep 24, 2021
Author

TheDutchCoder
Sep 23, 2021
Author

rarkins Sep 23, 2021
Maintainer

TheDutchCoder
Sep 23, 2021
Author