Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migratePresets #10111

Merged
merged 3 commits into from May 22, 2021
Merged

feat: migratePresets #10111

merged 3 commits into from May 22, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented May 22, 2021

Changes:

Adds new config option migratePresets which allows for admin control of migrating removed or renamed presets.

Context:

Closes #9209

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice May 22, 2021 14:15
@viceice viceice requested a review from HonkingGoose May 22, 2021 14:18
lib/config/definitions.ts Show resolved Hide resolved
lib/config/definitions.ts Show resolved Hide resolved
@rarkins rarkins requested a review from viceice May 22, 2021 14:33
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a docs issue, otherwise LGTM. Would prefer to wait for @HonkingGoose review

@@ -247,6 +247,24 @@ If left as default (null), a random short ID will be selected.

## logFileLevel

## migratePresets

Use this is you have repositories extending a particular preset but it has been removed or renamed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing. Typo?

docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins merged commit 66820cf into main May 22, 2021
@rarkins rarkins deleted the feat/9209-migrate-presets branch May 22, 2021 21:47
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support admin-only option for redirecting presets
4 participants